[Symfony4.4] Composer2 update#4724
Merged
okazy merged 13 commits intoEC-CUBE:experimental/symfony4.4from Oct 22, 2020
Merged
Conversation
…ony4.4 Symfony4.4対応
…experimental/symfony4.4
e3d0f78 to
86ba6f6
Compare
86ba6f6 to
3578566
Compare
Contributor
Author
|
別ブランチで検証中ですが、プラグインのアップデートがうまくいかない模様 |
Contributor
Author
package-api の改修でアップデートの E2Eテストが通ることを確認。 |
Contributor
Author
|
プラグインの依存関係をチェックする箇所で、本体側にも |
Contributor
Author
|
symfony/flex の依存関係の影響?で、 symfony-cmd が自動実行されない場合がある php composer.phar --version
Composer version 2.0.0-RC2 2020-10-14 21:34:07
php composer.phar install
The "symfony/flex" plugin was skipped because it is not compatible with Composer 2+. Make sure to update it to version 1.9.8 or greater.
...snip
> symfony-cmd
sh: symfony-cmd: command not found
Script symfony-cmd handling the auto-scripts event returned with error code 127
Script @auto-scripts was called via post-install-cmd |
Contributor
Author
これの模様 |
Contributor
Author
|
AppVeyor 落ちてますが、個人アカウントの方では通っているのでガチャだと思われます(僕の権限だと再実行できない |
Contributor
|
ありがとうございます。再実行しました。 |
okazy
approved these changes
Oct 20, 2020
Contributor
okazy
left a comment
There was a problem hiding this comment.
テスト通りました！
ソースコードの変更内容も問題ありませんでした。
Contributor
|
動作テストをしました。
Details |
Contributor
|
ありがとうございます！取り込みました。 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
Details
方針(Policy)
実装に関する補足(Appendix)
composer 2.0 の使用方法
php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" php composer-setup.php php composer.phar selfupdate --preview php composer.phar -V Composer version 2.0.0-RC1 2020-09-10 15:39:45テスト（Test)
ec-cube/plugin-installer が取り込まれれば、 GitHub Actions や travis-ci で動作確認可能2.0ブランチに取り込んでいただきました相談（Discussion）
plugin-installer: "~0.0.6 || ^2.0@dev"としておけばプラグイン側の記述は不要マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目