Merged
Conversation
chihiro-adachi
approved these changes
Feb 23, 2018
okazy
approved these changes
Feb 23, 2018
Contributor
Author
|
|
28fa832 to
3a2d0d4
Compare
Contributor
Author
|
experimental/sf ブランチでは、 Doctrine Proxy を読み込むタイミングの関係で、この修正をしなくても動作する模様。 |
11 tasks
Merged
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
方針(Policy)
ShoppingService::setNonMember()を追加実装に関する補足(Appendix)
activeプロパティも serialize/unserialize しろとあるが、 EC-CUBE の場合はUserProviderInterface::loadUserByUsername()で有効無効判定をしているため不要ShoppingService::setNonMember(),ShoppingService::getNonMember()を使用する必要があるテスト(Test)
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト