[DYN-7697] Crash with Periodic Run #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
approved these changes
Oct 31, 2024
reddyashish
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR aims to address DYN-7697 where enabling Periodic mode in TuneUp causes Dynamo to crash.
From what I can see this occurs when:
Please let me know if there are other scenarios where this crash might happen.
Dynamo was crashing because
ResetProfiledNodeswas trying to clear node collections that belonged to a different thread than the Dispatcher. I wrappedResetProfiledNodesinuiContext.Send, which seems to solve this issue.Please note that TuneUp will still enforce Manual mode when a new graph is opened.
Checked if this change does not break Dynamo in Civils3D. Seems okay.
@QilongTang
@reddyashish
@dnenov
@Amoursol