Skip to content

Conversation

@Enzo707
Copy link
Contributor

@Enzo707 Enzo707 commented May 31, 2023

This PR migrates notifications-panel version from 0.0.3 to 0.0.4

@Enzo707 Enzo707 changed the title chore(package.json):update-notifications-panel-version-to-0.0.4 chore:update-notifications-panel-version-to-0.0.4 May 31, 2023
@Enzo707 Enzo707 force-pushed the feature/update-notifications-panel-version branch 2 times, most recently from 41e6d2e to 0f51bb9 Compare May 31, 2023 22:53
@Enzo707 Enzo707 force-pushed the feature/update-notifications-panel-version branch from 0f51bb9 to 1ae5d92 Compare June 1, 2023 00:31
package.json Outdated
"publishConfig": {
"access": "public"
"access": "public",
"registry": "https://registry.npmjs.org"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to add this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to publish the npm package manually before I realized we got a pipeline. I'll remove it

@QilongTang
Copy link
Contributor

The package version need to be updated to 0.0.23

@QilongTang
Copy link
Contributor

@Enzo707 @avidit any insights on why the PR check would fail?

@Enzo707 Enzo707 force-pushed the feature/update-notifications-panel-version branch 2 times, most recently from 8627a89 to 2770c08 Compare June 1, 2023 15:33
@QilongTang
Copy link
Contributor

The package-lock.json still does not feel right.. Maybe disconnect with VPN and try the npm install again

@reddyashish
Copy link
Contributor

reddyashish commented Jun 1, 2023

I don't think there should there be any changes to package-lock json in this PR. Just the version update in the package.json.. the build passes now

@Enzo707 Enzo707 force-pushed the feature/update-notifications-panel-version branch from 2770c08 to 9e57fe7 Compare June 1, 2023 17:08
@avidit
Copy link
Contributor

avidit commented Jun 1, 2023

@Enzo707 @avidit any insights on why the PR check would fail?

Worked with @Enzo707 and resolved the issue

@QilongTang
Copy link
Contributor

I don't think there should there be any changes to package-lock json in this PR. Just the version update in the package.json.. the build passes now

Cool, I was about to push my changes but I found you guys worked it out

@QilongTang QilongTang merged commit 2219386 into DynamoDS:master Jun 1, 2023
@QilongTang
Copy link
Contributor

@Enzo707 @avidit Please file a new Github release to trigger the release pipeline, there are plenty examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants