Skip to content

Conversation

@twastvedt
Copy link
Contributor

@twastvedt twastvedt commented Jul 26, 2024

Purpose

Currently Dynamo Revit contains a copy of Dynamo's Selection node text formatting logic. This PR removes the duplicated code so that Dynamo Revit nodes use Dynamo's base selection node logic to format their textual representation (list of element ids).

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@Mikhinja Mikhinja merged commit b3d5506 into DynamoDS:master Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants