Skip to content

Conversation

@ZiyunShang
Copy link
Collaborator

@ZiyunShang ZiyunShang commented Apr 8, 2021

Purpose

REVIT-166657

Some more info :
DynamoDS/Dynamo#9934
DynamoDS/Dynamo#9377

I have the same opinion with alfarok that when toggling "Revit Background Preview", it has no need to force a regeneration of the render packages for all nodes.
I think we can change "Active" to virtual, so it can be overridden in inherited classes.

PS: This PR can not be merged until DynamoRevit update the new DynamoCore Libs. ( at least has this change DynamoDS/Dynamo#11597 )

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

@ShengxiZhang @wangyangshi

FYIs

@mjkkirschner @QilongTang @Amoursol

@ZiyunShang
Copy link
Collaborator Author

The PR to Dynamo has been merged, but this need to wait the Dynamo libs upgrade in DynamoRevit.

@QilongTang
Copy link
Contributor

@ZiyunShang Do you prefer to make this an open PR till then or our team can release 2.12.0 beta nugets for you to close this PR. Let us know. Thanks.

@ZiyunShang
Copy link
Collaborator Author

Hi @QilongTang , We plan to have a Dynamo integration in early May. Will there be a stable version 2.12.0? If not, I may need you to release a beta package.

@QilongTang
Copy link
Contributor

hi @ZiyunShang , I'm afraid there will not be a stable release of Dynamo 2.12.0 soon. Due to the nature that we are making a lot of new UI functionalities, expect the 2.12.0 release cycle to be a bit longer than usual.

@ZiyunShang
Copy link
Collaborator Author

ZiyunShang commented Apr 13, 2021

hi @ZiyunShang , I'm afraid there will not be a stable release of Dynamo 2.12.0 soon. Due to the nature that we are making a lot of new UI functionalities, expect the 2.12.0 release cycle to be a bit longer than usual.

OK, If I upgrade Dynamo Libs to 2.12.0 (beta) here, is there a DynamoCoreRuntime package available that will allow me to make a new version of revit-d4r?

@QilongTang
Copy link
Contributor

hi @ZiyunShang , I'm afraid there will not be a stable release of Dynamo 2.12.0 soon. Due to the nature that we are making a lot of new UI functionalities, expect the 2.12.0 release cycle to be a bit longer than usual.

OK, If I upgrade Dynamo Libs to 2.12.0 (beta) here, is there a DynamoCoreRuntime package available that will allow me to make a new version of revit-d4r?

There will be plenty beta ones but no prod until we think the 2.12.0 quality is good to release..

@ZiyunShang
Copy link
Collaborator Author

#2725 Dynamo has been upgraded to 2.12.0, so this change can be merged now.

@ZiyunShang ZiyunShang merged commit b29b358 into DynamoDS:master Jul 20, 2021
@ZiyunShang ZiyunShang deleted the UpdateRevitWatch3DViewModel branch July 20, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants