-
Notifications
You must be signed in to change notification settings - Fork 199
Override property - Active #2687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override property - Active #2687
Conversation
|
The PR to Dynamo has been merged, but this need to wait the Dynamo libs upgrade in DynamoRevit. |
|
@ZiyunShang Do you prefer to make this an open PR till then or our team can release 2.12.0 beta nugets for you to close this PR. Let us know. Thanks. |
|
Hi @QilongTang , We plan to have a Dynamo integration in early May. Will there be a stable version 2.12.0? If not, I may need you to release a beta package. |
|
hi @ZiyunShang , I'm afraid there will not be a stable release of Dynamo 2.12.0 soon. Due to the nature that we are making a lot of new UI functionalities, expect the 2.12.0 release cycle to be a bit longer than usual. |
OK, If I upgrade Dynamo Libs to 2.12.0 (beta) here, is there a DynamoCoreRuntime package available that will allow me to make a new version of revit-d4r? |
There will be plenty beta ones but no prod until we think the 2.12.0 quality is good to release.. |
|
#2725 Dynamo has been upgraded to 2.12.0, so this change can be merged now. |
Purpose
REVIT-166657
Some more info :
DynamoDS/Dynamo#9934
DynamoDS/Dynamo#9377
I have the same opinion with alfarok that when toggling "Revit Background Preview", it has no need to force a regeneration of the render packages for all nodes.
I think we can change "Active" to virtual, so it can be overridden in inherited classes.
PS: This PR can not be merged until DynamoRevit update the new DynamoCore Libs. ( at least has this change DynamoDS/Dynamo#11597 )
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@ShengxiZhang @wangyangshi
FYIs
@mjkkirschner @QilongTang @Amoursol