Make libG version robust. #2342
Conversation
| /// </summary> | ||
| /// <param name="preloaderLocation"></param> | ||
| /// <returns></returns> | ||
| internal static Version PreloadLibGVersion(string preloaderLocation) |
There was a problem hiding this comment.
@mjkkirschner @aparajit-pratap I feel this tech debt is good for now due to the nature of the bug, of course DynamoCore will provide API pretty soon to get the correct libG version based on ASM version and libG preloader available. If there is no objection, let us fix this as part of next DynamoCore release since it is directly related to host integration support.
There was a problem hiding this comment.
@mjkkirschner @aparajit-pratap @AndyDu1985 @ZiyunShang More details for you, I have confirmed with @angelowang that Civil Team dose not have the same bug here because of their implementation of GetGeometryFactoryPath() is different than D4R. See: https://git.autodesk.com/Civil3D/Civil3D/blob/master/Source/Dynamo/AcDynamo/GeometryFactoryPathDetector.cs#L38
src/DynamoRevit/DynamoRevit.cs
Outdated
| var regExp = new Regex(@"^libg_(\d\d\d)_(\d)_(\d)$", RegexOptions.IgnoreCase); | ||
| { | ||
| var match = regExp.Match(preloaderLocation); | ||
| if (match.Groups.Count == 4) |
There was a problem hiding this comment.
just curious, what is match group 0?
There was a problem hiding this comment.
The whole word, such as "libg_22X_X_X".
|
@AndyDu1985 looks good to me, just had one comment and a question - but feel free to ignore them if you disagree. |
| @@ -1,3 +1,7 @@ | |||
| ## 0.1.0 | |||
| * The version of master branch will be start with 0.1.x, and Revit2020 branch will still be 0.0.xx. | |||
| * LibG should be more version compatible. | |||
There was a problem hiding this comment.
What do you mean by this statement exactly?
There was a problem hiding this comment.
The version for master branch will be like 0.1.x, and RC2.1.0_Revit2020 will be 0.0.x, and in the future, after a new major branch is split, that branch will have version 0.1.x, and the master will be 0.2.x.
I add the statement just to help others to understand how we define version number.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Make libG version robust. This is a temporary fix, will refactor code later.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @mjkkirschner @ZiyunShang