Revit element selection nodes should serialize and deserialize properly in Json #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "Select a face.", | ||
| "Face of Element Id") { } | ||
|
|
||
| [JsonConstructor] |
Member
There was a problem hiding this comment.
so you'll need to add these for all derived selection types right?
Contributor
Author
There was a problem hiding this comment.
yes I believe so, I only did this first one as an example so far. I am still figuring out why I can't modify the selection once reopening the json file before I add them all.
alfarok
commented
Sep 5, 2017
| [Category("SmokeTests")] | ||
| [TestModel(@".\Selection\Selection.rfa")] | ||
| public void SelectionVerifyElementID() | ||
| { |
Contributor
Author
There was a problem hiding this comment.
This test:
- opens an xml graph w/ a model element selection node
- verifies the selectionId and node UUID
- saves to temporary json file
- closes and reopens the graph
- verifies data remains unchanged after execution
- deletes temporary json file
Contributor
Author
|
LGTM from @mjkkirschner |
This was referenced Sep 6, 2017
This was referenced Sep 15, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
QNTM-1284
The purpose of this PR is to enable the serialization and deserialization of Revit element selection nodes in Json. Previously Revit/Dynamo would freeze when attempting save a graph containing Revit selection nodes and the Json file is never written. The selection node should also maintain the Revit element id that is referenced so it will automatically be recognized when reopening a graph.
Supplemental to Dynamo PR #8131
All RTF selection tests are passing including new tests:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
FYIs