Skip to content

Conversation

@scottmitchell
Copy link
Collaborator

  • Refactor PackageDependencies property

  • Add test to verify multiple packages not listed as dependencies for one node

  • Keep original package dependency by default and add API to void original package dependency

  • Add comment

  • Move helper methods out of properties region

  • Fix IsLoaded logic

  • Update test .dyn to avoid serialization test failures

  • Exclude new dyn from serialization tests

  • Use preexisting method to exclude test dyn from serialization tests

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

* Refactor PackageDependencies property

* Add test to verify multiple packages not listed as dependencies for one node

* Keep original package dependency by default and add API to void original package dependency

* Add comment

* Move helper methods out of properties region

* Fix IsLoaded logic

* Update test .dyn to avoid serialization test failures

* Exclude new dyn from serialization tests

* Use preexisting method to exclude test dyn from serialization tests
@QilongTang
Copy link
Contributor

LGTM

@QilongTang QilongTang added the LGTM Looks good to me label Jun 28, 2019
@scottmitchell scottmitchell merged commit 1ebcc54 into DynamoDS:RC2.3.0_master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM Looks good to me

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants