Skip to content

Conversation

@reddyashish
Copy link
Contributor

Purpose

This PR is still Work in progress.

This addresses the issue that occurs when a List with nested empty and non-empty lists is passed to a function. It fails during replication process. When determining the method resolution, the length of the arrayStats list had to be checked and the reducedParams list has to be cleared only when the arrayStats has any elements.
https://github.com/reddyashish/Dynamo/blob/aa841e4758a34a991214e9cf660e9fd002f7495b/src/Engine/ProtoCore/Lang/Replication/Replicator.cs#L243

Capture

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@aparajit-pratap @mjkkirschner @saintentropy

Hetergenous nested empty list fix. Work in progress still.
@reddyashish
Copy link
Contributor Author

Duplicate of #9559. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant