Warn users submitting crash reports that they must be signed into GitHub #9519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DYN-1491
This PR adds a tooltip to the
Submit Bug To GitHubbutton in theCrashPromptdialog box warning users they must be signed in before attempting to launch a pre-filled crash report on GitHub. If the user clicks the button and is not logged in they will likely face a414or404depending on several factors. This is a result of #9393 as users used to be directed to issues as opposed to new issues which requires auth. The redirect url cannot handle the long content from the crash report often resulting in a414. This could be avoided by using aGitHubAppand making a post request.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @QilongTang