cherry pick performance profiling of first load of trace data (#9465) #9505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add element binding test to core * re-enabe callsite tests, update files, and load deps manually * add timing test add new test file with 1500 trace elements make traceBinder internal expose protoCore internals to dynamoCoreTests
QilongTang
reviewed
Feb 20, 2019
| "ScaleFactor": 1.0, | ||
| "HasRunWithoutCrash": true, | ||
| "IsVisibleInDynamoLibrary": true, | ||
| "Version": "2.2.0.3965", |
Contributor
There was a problem hiding this comment.
Can you fix the versions of these new DYNs to be 2.1.0? Ideally, there should be no DYNs from a future version in this branch. I have seen this happened in the past and bring unexpected behavior to tests and users.
Contributor
|
Other than the version conflicts, once we have the branch build going green, then LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick:
#9465