fix OpenIfSaved API for DynamoPlayer #9443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he model command so the view loads the right filePath...
Contributor
|
@mjkkirschner Can you update the unit tests introduced in #7061? For example, in the unit test ViewModel.OpenIfSavedCommand.Execute(new Dynamo.Models.DynamoModel.OpenFileCommand(openPath));
//assert the path updated
Assert.AreEqual(ViewModel.FilePath ,openPath);Other than that, LGTM |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
update the filePath property of the DynamoView as deserializing the view block of json files relies on it being correct.
@Racel Not sure what you want to do with this change regarding 2.1 x 2.2.
In terms of risk, it's small because this API is not called by many clients, I think only Player calls this, perhaps some extensions as well.
While this does not cause a crash, it does cause graphs to fail to open via player edit button without first closing dynamo.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@Racel @smangarole