Skip to content

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Jan 16, 2019

  • fix to List.CartesianProduct node

  • add DYN file for test

  • revised fix

  • reuse code

  • add string overload for ValueAtIndex method for for loops

  • add for loop test with single value to array promotion

Purpose

Cherry-pick #9431

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

FYIs

@mjkkirschner @QilongTang

* fix to List.CartesianProduct node

* add DYN file for test

* revised fix

* reuse code

* add string overload for ValueAtIndex method for for loops

* add for loop test with single value to array promotion
@aparajit-pratap aparajit-pratap merged commit 2b25007 into DynamoDS:master Jan 16, 2019
@aparajit-pratap aparajit-pratap deleted the forLoopIndex branch January 16, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant