Skip to content

Conversation

@mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Oct 15, 2018

Purpose

It appears that when this rename occurred the new property KeepListStructure raised the change notification with the old string "shouldKeepListStructure" but then checked for the new string "KeeplistStructure"

change it in one spot:
https://jira.autodesk.com/browse/QNTM-4759

TODO:

  • add a regression that will catch this runtime interactive behavior.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@ramramps

FYIs

@Racel @jnealb

@mjkkirschner mjkkirschner changed the title Update NodeModel.cs KeepListStructure list@level functionality should work. Oct 16, 2018
@mjkkirschner mjkkirschner added 2.x Issues related to 2.x versions of Dynamo. PTAL Please Take A Look 👀 bug labels Oct 16, 2018
@ramramps
Copy link
Collaborator

LGTM

@mjkkirschner
Copy link
Member Author

Test added

@mjkkirschner mjkkirschner merged commit e1cc811 into master Nov 20, 2018
@QilongTang QilongTang mentioned this pull request Dec 4, 2018
@QilongTang QilongTang mentioned this pull request Feb 12, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.x Issues related to 2.x versions of Dynamo. bug PTAL Please Take A Look 👀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants