Skip to content

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Apr 5, 2018

Update Build Script to remove beta and Revision number so that nuget
package built will be actual release nugets

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

QNTM-3916 D4R Build Only job is pulling the master packages while building

This PR will be merged once we have finalized Release Candidate and we are ready to publish the 2.0.0 nugets to nuget.org. e.g. nugets will be 2.0.0 instead of current 2.0.0-beta4xxx

There will be another PR DynamoDS/DynamoRevit#1982 in DynamoRevit RC branches to grab the actual RC nugets

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner @ramramps

FYIs

@smangarole

Update Build Script to remove beta and Revision number so that nuget
package built will be actual release nugets
@QilongTang QilongTang added DNM Do not merge. For PRs. PTAL Please Take A Look 👀 labels Apr 5, 2018
@QilongTang
Copy link
Contributor Author

@ramramps @mjkkirschner @alfarok @ColinDayOrg @smangarole @Racel @jnealb It seems we are finalized on Dynamo 2.0 Code changes, I will merge this in now so we can publish the official 2.0 nugets for other repos to consume

@QilongTang QilongTang removed DNM Do not merge. For PRs. PTAL Please Take A Look 👀 labels Apr 6, 2018
@QilongTang QilongTang merged commit 0cc99b4 into RC2.0.0_master Apr 6, 2018
@mjkkirschner
Copy link
Member

🎉

@QilongTang QilongTang mentioned this pull request Apr 6, 2018
7 tasks
@QilongTang QilongTang deleted the UpdateNuspec branch April 12, 2018 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants