Skip to content

Conversation

@ColinDayOrg
Copy link
Contributor

Purpose

This PR is to cherry-pick #8768 from master into RC2.0.0 to fix the up/down arrow key issue (and also fix the related enter key issue that was found)

Note the CI box below is not checked due to the change being in librarie.min.js only

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner

After investigating the errors in the EngOps check it was thought that these changes could not have caused the current failures. Other PRs have also shown the same issues. Given all of that, this PR is being merged.
@mjkkirschner
Copy link
Member

LGTM

@ColinDayOrg ColinDayOrg merged commit 84048f5 into RC2.0.0_master Mar 23, 2018
@ColinDayOrg ColinDayOrg deleted the RC2.0.0_master_QNTM-3710 branch March 23, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants