fix build #16610
Merged
fix build #16610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Purpose: Add a new InternalsVisibleTo entry to permit the PythonMigrationViewExtension assembly to access internal members of DynamoCoreWpf to resolve a build issue.
- Adds friend assembly: PythonMigrationViewExtension
- Extends internal visibility surface of DynamoCoreWpf
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
3 tasks
Contributor
Author
|
@avidit can you approve this PR so that this can be merged first before we continue addressing the other failures in the build pipeline? |
avidit
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix build.
OnCurrentWorkspaceClearedinPythonMigrationViewExtensionusesGuidesManager.CloseRealTimeInfoWindow, which is marked internal inDynamoCoreWpf, and this wasn't accessible in the view extension.Declarations
Check these if you believe they are true
Release Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of