[DYN-9407] Handle PhoneticRun elements for import-excel node #16607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9407
Contributor
aparajit-pratap
left a comment
There was a problem hiding this comment.
Can you add a test case?
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds logic to exclude PhoneticRun elements (phonetic guides) from extracted shared string values when importing Excel via OpenXML.
- Replaces direct InnerText access with a new helper that filters out phonetic runs.
- Introduces GetSharedStringText and IsInsidePhoneticRun helper methods to process SharedStringItem contents.
| if (cell.CellValue.TryGetInt(out var index)) | ||
| { | ||
| return sharedStringTable.ElementAt(index).InnerText; | ||
| return GetSharedStringText(sharedStringTable.ElementAt(index)); |
There was a problem hiding this comment.
sharedStringTable.ElementAt(index) will iterate to the index each call; if this method executes for many cells, prefer direct indexed access (e.g., sharedStringTable.ChildElements[index] or caching Elements().ToList()) to avoid repeated enumeration.
Contributor
Author
|
@aparajit-pratap added the test and addressed comments. |
Contributor
Author
aparajit-pratap
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-9407
Handling PhoneticRun elements for excel nodes (https://learn.microsoft.com/en-us/dotnet/api/documentformat.openxml.spreadsheet.phoneticrun?view=openxml-3.0.1). These characters should not be displayed when using OpenXMLImportExcel node.
Declarations
Check these if you believe they are true
Release Notes
[DYN-9407] Handle PhoneticRun elements for import-excel node
Reviewers