DYN-9645: finishing package publish fix #16601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- race condition was preventing packages to be correctly displayed as successfully published - removing ClearAllEntries from running as part of the publishing routine resolves the issue - correctly uses ClearAllEntries only after the user interacts with the UI after the package is published
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9645
benglin
reviewed
Oct 17, 2025
| }); | ||
| OnPublishSuccess(); | ||
| // Don't clear entries on success - user needs to see the success state | ||
| // Clearing will happen when user clicks Done/Reset from the success page |
Contributor
There was a problem hiding this comment.
Nice -- this looks like a logical change, since clearing triggers a lot of property change events, and there’s no real urgency to clear the contents right away.
| } | ||
|
|
||
| if (Name.Length <= 0 && !PackageContents.Any()) | ||
| if (Name.Length <= 0 && !PackageContents.Any() && !PreviewPackageContents.Any()) |
Contributor
There was a problem hiding this comment.
I think the addition of PreviewPackageContents wasn’t intended to fix the issue, but rather for completeness?
That said, it wasn’t immediately clear to me what PreviewPackageContents was for, so I did some Cursoring to find out. After some back-and-forth, here’s what I found -- if you could integrate this into the code, it might help future readers (and AI agents) understand it more easily. Thanks!
/// <summary>
/// Stores the raw files/folders the user has added for package publishing. Items represent
/// files in their current disk locations, NOT their final locations in the published package.
/// This collection is modified when users add files via `ShowAddFileDialogAndAddCommand`,
/// add directories via `SelectDirectoryAndAddFilesRecursivelyCommand`, or remove items via
/// `RemoveItemCommand`.
/// </summary>
public ObservableCollection<PackageItemRootViewModel> PackageContents { get; set; }
/// <summary>
/// Preview of the final package directory structure before publishing. Shows how files in
/// PackageContents will be organized in the published package. It reorganizes the files
/// into the standard Dynamo package folders (`bin/`, `dyf/`, `extra/`, `doc/`, `pkg.json`)
/// if `RetainFolderStructureOverride == false`, or preserves the user's existing folder
/// structure from PackageContents if `RetainFolderStructureOverride == true`.
/// </summary>
public ObservableCollection<PackageItemRootViewModel> PreviewPackageContents { get; set; }- added detailed property descriptions for PackageContents and PreviewPackageContents
…nenov/Dynamo into DYN-9645-pm-publish-dyf-ui-fix
QilongTang
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Problem
Packages published successfully but showed validation error instead of success page.
Root Cause
ClearAllEntries() was called immediately after OnPublishSuccess(), clearing form data before the frontend received the success notification, causing validation to fail.
Declarations
Check these if you believe they are true
Release Notes
Reviewers
@zeusongit
@benglin
FYIs