DYN-9616: [Regression] Fix pan tool to remain active until the user choose to deactivate it #16559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the mouse release event handler to check for the middle mouse button specifically when toggling pan mode, ensuring correct behavior when releasing the middle mouse button.
A comment was added to explain that pan mode is toggled only when not connecting a port and when panning with the middle mouse button. This improves code readability and maintainability.
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9616
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression where the pan tool would deactivate unintentionally when other mouse buttons were released. The fix ensures that pan mode is only toggled when specifically releasing the middle mouse button that initiated the panning operation.
- Modified the mouse release event handler to check for the specific middle mouse button release
- Changed from checking
e.MiddleButton == MouseButtonState.Releasedtoe.ChangedButton == MouseButton.Middle && e.ButtonState == MouseButtonState.Released - Added a clarifying comment explaining the condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Updated the mouse release event handler to check for the middle mouse button specifically when toggling pan mode, ensuring correct behavior when releasing the middle mouse button. This was conflicting with the
PanModestateCases:
User switches to
PanModeCursor changes to
Handand stays in this mode until either the user switches off thePanModeor uses the mouse middle button to pan.User uses mouse middle button to pan:
Cursor changes to
Handfor the duration while the mouse middle button is pressed, and switches back to normal when released.User is panning while in between connecting ports:
Cursor changes to
connectmode until the connection is dropped or completed.When in
PanModeclicking on ports won't initiate connection mode.Declarations
Check these if you believe they are true
Release Notes
Fix pan tool to remain active until the user choose to deactivate it
Reviewers