Skip to content

Conversation

@reddyashish
Copy link
Contributor

Purpose

Related to https://jira.autodesk.com/browse/DYN-8952.

This should fix the custom group styles duplicating in the Revit environment when Dynamo is reopened. When dynamo is closed in host environment, the styles are still in memory and when preferencesVM is initialized, they are added again.

Tested it on Revit and sandbox with these changes.

Declarations

Check these if you believe they are true

Release Notes

[DYN-8952] Fix custom group styles duplicating issue on host environments.

Reviewers

@DynamoDS/eidos

(cherry picked from commit b711e1a)
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8952

@zeusongit zeusongit requested review from a team and Copilot October 1, 2025 16:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where custom group styles were being duplicated in Dynamo when reopened in host environments like Revit. The issue occurred because the styles remained in memory after Dynamo was closed, and when the PreferencesViewModel was reinitialized, the custom styles were added again on top of the existing ones.

Copy link
Contributor

@zeusongit zeusongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment from Copilot, you can take a call on it.

@zeusongit zeusongit merged commit c06b751 into DynamoDS:master Oct 6, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants