DYN-9533: Update Dynamo for LibG for ASM232 #16557
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9533
There was a problem hiding this comment.
Pull Request Overview
Updates Dynamo to support LibG version 232.0.0 for ASM232 compatibility, replacing the previous 231.0.0 version throughout the codebase.
- Updates all project files to reference DynamoVisualProgramming.LibG_232_0_0 version 4.0.0.2726
- Removes ASM 230 support and related test code while adding ASM 232 support
- Updates version lists in preloader, test configurations, and startup utilities
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/System/IntegrationTests/DynamoApplicationTests.cs | Added version 232.0.0 to supported versions list for testing |
| test/Libraries/WorkflowTests/WorkflowTests.csproj | Updated LibG package reference from 231 to 232 |
| test/Libraries/TestServices/TestSessionConfiguration.cs | Added version 232.0.0 to supported LibG versions |
| test/Libraries/TestServices/TestServices.csproj | Updated LibG package reference from 231 to 232 |
| test/Libraries/GeometryColorTests/GeometryColorTests.csproj | Updated LibG package reference from 231 to 232 |
| test/Libraries/DynamoPythonTests/DynamoPythonTests.csproj | Updated LibG package reference from 231 to 232 |
| test/Libraries/AnalysisTests/AnalysisTests.csproj | Updated LibG package reference from 231 to 232 |
| test/DynamoCoreTests/libGPreloaderTests.cs | Removed ASM 230 specific test method |
| test/DynamoCoreTests/Logging/AnalyticsServiceTest.cs | Updated version lists to include 232.0.0 |
| src/Tools/NodeDocumentationMarkdownGenerator/NodeDocumentationMarkdownGenerator.csproj | Updated LibG package reference from 231 to 232 |
| src/Tools/DynamoShapeManager/Utilities.cs | Removed ASM 230 DLL names and validation, added ASM 232 support |
| src/Tools/DynamoShapeManager/Preloader.cs | Updated supported versions to include 232.0.0 |
| src/Libraries/Tesellation/Tessellation.csproj | Updated LibG package reference from 231 to 232 |
| src/Libraries/GeometryUIWpf/GeometryUIWpf.csproj | Updated LibG package reference from 231 to 232 |
| src/Libraries/GeometryUI/GeometryUI.csproj | Updated LibG package reference from 231 to 232 |
| src/Libraries/GeometryColor/GeometryColor.csproj | Updated LibG package reference from 231 to 232 |
| src/Libraries/CoreNodes/CoreNodes.csproj | Updated LibG package reference from 231 to 232 |
| src/Libraries/Analysis/Analysis.csproj | Updated LibG package reference from 231 to 232 |
| src/DynamoManipulation/DynamoManipulation.csproj | Updated LibG package reference from 231 to 232 |
| src/DynamoCoreWpf/DynamoCoreWpf.csproj | Updated LibG package reference from 231 to 232 |
| src/DynamoCore/DynamoCore.csproj | Updated LibG package references and build properties for 232 support |
| src/DynamoApplications/StartupUtils.cs | Updated supported versions to include 232.0.0 |
| src/Config/CS_SDK.props | Updated LIBGVer property to libg_232_0_0 |
jasonstratton
left a comment
There was a problem hiding this comment.
Just a couple of clarifying questions. If they are good, then I'm good.
| <PackageReference Include="DynamoVisualProgramming.LibG_231_0_0_debug" Version="3.6.0.2655" Condition=" '$(Configuration)' == 'Debug' " GeneratePathProperty="true" ExcludeAssets="runtime"/> | ||
| <PackageReference Include="DynamoVisualProgramming.LibG_231_0_0" Version="4.0.0.2726" GeneratePathProperty="true" ExcludeAssets="all"/> | ||
| <PackageReference Include="DynamoVisualProgramming.LibG_232_0_0" Version="4.0.0.2726" Condition=" '$(Configuration)' == 'Release' " GeneratePathProperty="true" ExcludeAssets="runtime"/> | ||
| <PackageReference Include="DynamoVisualProgramming.LibG_232_0_0_debug" Version="4.0.0.2726" Condition=" '$(Configuration)' == 'Debug' " GeneratePathProperty="true" ExcludeAssets="runtime"/> |
There was a problem hiding this comment.
These all reference the same version of LibG 4.0.0.2726
Should LibG 231 reference 3.6.0.2655?
There was a problem hiding this comment.
LibG 231 also has the same version (as it uses the same formula to calculate the build number).
| }); | ||
| } | ||
|
|
||
| [Test] |
There was a problem hiding this comment.
There is no corresponding ASM231InstallationsAreValidated or ASM232InstallationsAreValidated tests.
Is the test no longer valid or needed?
There was a problem hiding this comment.
Oh, is it because we're using ASC now?
There was a problem hiding this comment.
Yes, I believe it's because we're using ASC now. Jorgen initially stopped testing this for ASM 231 when he introduced ASC. Previously we had this validation test to check if an installation of an Autodesk product had all of the DLLs required by Dynamo to load ASM. Now, ASC always ensures that is true so we don't need to validate it anymore.
Purpose
Update Dynamo for LibG for ASM232 support.
Declarations
Check these if you believe they are true
Release Notes
Add support and references for geometry library using newer version of Autodesk geometry kernel, ASM 232.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of