Skip to content

Conversation

@zeusongit
Copy link
Contributor

Purpose

Update Magick.NET packages to version 14.8.2

Declarations

Check these if you believe they are true

Release Notes

Update Magick.NET packages to version 14.8.2

Reviewers

Upgraded Magick.NET.Core and Magick.NET-Q8-AnyCPU package references from version 7.x to 14.8.2 to ensure compatibility with the latest features and bug fixes.
@zeusongit zeusongit requested review from a team and Copilot September 29, 2025 21:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Magick.NET packages from version 7.x to version 14.8.2 in the NodeDocumentationMarkdownGenerator project, representing a major version upgrade for image processing capabilities.

  • Updates Magick.NET.Core from version 7.0.1 to 14.8.2
  • Updates Magick.NET-Q8-AnyCPU from version 7.24.1 to 14.8.2

@mjkkirschner
Copy link
Member

@zeusongit - one thing I do recall here is that the library and the .net wrapper had different / confusing licenses, we should check if anything has changed with a move to these new versions.

@avidit
Copy link
Contributor

avidit commented Sep 29, 2025

Thanks, hope all these Dependabot alerts will be resolved by this PR

@zeusongit
Copy link
Contributor Author

@zeusongit - one thing I do recall here is that the library and the .net wrapper had different / confusing licenses, we should check if anything has changed with a move to these new versions.

Here is the wrapper license: https://github.com/dlemstra/Magick.NET/blob/main/License.txt and the library: https://imagemagick.org/script/license.php seems like we need to add attributions as per the library license (if not already)

@zeusongit zeusongit changed the title Update Magick.NET packages to version 14.8.2 DYN-9626: Update Magick.NET packages to version 14.8.2 Sep 30, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9626

@benglin
Copy link
Contributor

benglin commented Oct 2, 2025

Good call out, @mjkkirschner! 👍

seems like we need to add attributions as per the library license (if not already)

I think we already have that listed in three parts of the ABOUT.txt file, @zeusongit:

From the licensing page we can consolidate the three of the above sections into just two:

ImageMagick / Magick.NET-Q8-AnyCPU v14.8.2:
Copyright 1999-2025 ImageMagick Studio LLC

Licensed under the ImageMagick License (the "License"); you may not use
this file except in compliance with the License. You may obtain a copy 
of the License at

https://imagemagick.org/script/license.php

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
License for the specific language governing permissions and limitations
under the License.
Magick.NET.Core v14.8.2:
Copyright 2013 dlemstra
https://github.com/dlemstra/Magick.NET/blob/main/License.txt

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

What were changed

  • Updated version numbers from v7.0.1/v7.24.1 to v14.8.2
  • Updated ImageMagick copyright from 1999-2021 to 1999-2025
  • Added full ImageMagick license boilerplate (was just a link before)
  • Merged ImageMagick and Magick.NET-Q8-AnyCPU sections (same license)
  • Removed square brackets (as required by the license)
  • Eliminated duplicate attribution by combining related components

Replaces old Magick.NET.Core v7.0.1 and Magick.NET-Q8-AnyCPU v7.24.1 license entries with updated information for Magick.NET-Q8-AnyCPU v14.8.2 and Magick.NET.Core v14.8.2. Updates copyright years and license details.
@zeusongit zeusongit merged commit 94171e9 into DynamoDS:master Oct 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants