-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-9626: Update Magick.NET packages to version 14.8.2 #16544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upgraded Magick.NET.Core and Magick.NET-Q8-AnyCPU package references from version 7.x to 14.8.2 to ensure compatibility with the latest features and bug fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Magick.NET packages from version 7.x to version 14.8.2 in the NodeDocumentationMarkdownGenerator project, representing a major version upgrade for image processing capabilities.
- Updates Magick.NET.Core from version 7.0.1 to 14.8.2
- Updates Magick.NET-Q8-AnyCPU from version 7.24.1 to 14.8.2
src/Tools/NodeDocumentationMarkdownGenerator/NodeDocumentationMarkdownGenerator.csproj
Show resolved
Hide resolved
|
@zeusongit - one thing I do recall here is that the library and the .net wrapper had different / confusing licenses, we should check if anything has changed with a move to these new versions. |
|
Thanks, hope all these Dependabot alerts will be resolved by this PR |
Here is the wrapper license: https://github.com/dlemstra/Magick.NET/blob/main/License.txt and the library: https://imagemagick.org/script/license.php seems like we need to add attributions as per the library license (if not already) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9626
|
Good call out, @mjkkirschner! 👍
I think we already have that listed in three parts of the
From the licensing page we can consolidate the three of the above sections into just two: What were changed
|
Replaces old Magick.NET.Core v7.0.1 and Magick.NET-Q8-AnyCPU v7.24.1 license entries with updated information for Magick.NET-Q8-AnyCPU v14.8.2 and Magick.NET.Core v14.8.2. Updates copyright years and license details.
Purpose
Update Magick.NET packages to version 14.8.2
Declarations
Check these if you believe they are true
Release Notes
Update Magick.NET packages to version 14.8.2
Reviewers