DYN-9196:net10-migration-resolve long file paths #16520

dnenov · 2025-09-25T11:40:36Z

Purpose

A small part of the new .png resources shipped recently as part of the migration to net10 violate the max character restriction. The main reason is that we use unique file naming for identical node names with different overrides:

Autodesk.DesignScript.Geometry.CoordinateSystem.ByOriginVectors.Point-Vector-Vector.Large
Autodesk.DesignScript.Geometry.CoordinateSystem.ByOriginVectors.Point-Vector-Vector-Vector.Large

This PR resolves the path length conflicts by implementing hash-based renaming for problematic resource files, following the same approach used by the NodeDocumentationMarkdownGenerator. For example:

Autodesk.DesignScript.Geometry.CoordinateSystem.ByOriginVectors.Point-Vector-Vector.Large.png → a1b2c3d4e5f6.Large.png
Autodesk.DesignScript.Geometry.CoordinateSystem.ByOriginVectors.Point-Vector-Vector-Vector.Large.png → f6e5d4c3b2a1.Large.png

The hash names are generated using Dynamo.Utilities.Hash.GetHashFilenameFromString() to ensure uniqueness while keeping filenames short. Original names are preserved as comments in the updated .resx files for searchability.

Declarations

Check these if you believe they are true

Is documented according to the standards
The level of testing this PR includes is appropriate
Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Release Notes

created test to cover all resource file paths and prompts the long ones ( > 260 characters)
manually resolved the violating files

Reviewers

@zeusongit
@QilongTang
@avidit

FYIs

@saintentropy

- created test to cover all resource file paths and prompts the long ones ( > 260 characters) - manually resolved the violating files

github-actions

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9196

dnenov · 2025-09-25T11:42:50Z

test/DynamoCoreTests/ResourcePathLengthTests.cs

+    /// when resource paths become too long.
+    /// </summary>
+    [TestFixture]
+    public class ResourcePathLengthTests : UnitTestBase


@saintentropy I created a new test class here, thinking that we may want to reuse the resx transverse logic for further work, as per your original intent to do a follow-up job on the image resource analysis.

QilongTang · 2025-09-25T13:33:07Z

Oh interesting fix @dnenov , would you rebase this branch after your last fix, because it seems the only failure on the job is a test you already fixed
Dynamo.Tests.CodeBlockNodeTests.IntegerOverflow
FYI: @avidit

Copilot

Pull Request Overview

This PR resolves Windows path length limitation issues for .NET 10 migration by implementing a systematic approach to shorten resource file paths that exceed the 260-character limit. The main solution involves replacing verbose method override naming patterns with numerical identifiers and consolidating duplicate resources that reference identical image files.

Key changes:

Creates comprehensive test coverage to detect and prevent future long path issues
Shortens resource file paths by replacing parameter-based naming with numerical suffixes
Consolidates duplicate TSpline resources that reference the same underlying image files

Reviewed Changes

Copilot reviewed 2 out of 28 changed files in this pull request and generated 3 comments.

File	Description
test/DynamoCoreTests/ResourcePathLengthTests.cs	Adds comprehensive test suite to validate resource paths don't exceed Windows limits and detect problematic patterns
src/Libraries/GeometryUIWpf/ProtoGeometryImages.resx	Updates resource references to use shortened file paths, replacing verbose parameter names with numerical identifiers

test/DynamoCoreTests/ResourcePathLengthTests.cs

Copilot · 2025-09-25T13:58:06Z

test/DynamoCoreTests/ResourcePathLengthTests.cs

+            // Calculate estimated server path length
+            var serverPathLength = ESTIMATED_SERVER_PREFIX_LENGTH + relativePath.Length;


The server path length calculation only considers the relative path length but ignores intermediate directory structure. This may not accurately reflect the actual full path length on CI servers which could include additional nested directories.

Suggested change

// Calculate estimated server path length

var serverPathLength = ESTIMATED_SERVER_PREFIX_LENGTH + relativePath.Length;

// Calculate estimated server path length, including intermediate directories

var serverPathLength = ESTIMATED_SERVER_PREFIX_LENGTH + (actualPath.Length - Path.GetPathRoot(actualPath).Length);

dnenov · 2025-09-25T14:28:26Z

Oh interesting fix @dnenov , would you rebase this branch after your last fix, because it seems the only failure on the job is a test you already fixed Dynamo.Tests.CodeBlockNodeTests.IntegerOverflow FYI: @avidit

Yes, absolutely, will do. I do expect more devs to comment on this one, there are some arbitrary choices I made, so definitely expecting pushback or reconsideration.

aparajit-pratap · 2025-09-25T15:47:02Z

...ce.CreateMatch.TSplineEdge1-Edge1-int-bool-bool-int-double-bool-double-double-bool.Large.png

What are the changes made to these pngs?

The files were renamed. TSplineEdge1-Edge1-int-bool-bool-int-double-bool-double-double-bool substring is removed from the file name. The resource now points to the new, trimmed file name. The long file paths no longer break the build, that's was the whole logic here.

...y/LargeIcons/Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.FlattenVertices.Large.png

aparajit-pratap

@dnenov so from what I understand, you just renamed some png files, and that fixed the issue; there are no code changes involved to get the icons to work with these new filenames, is that correct?

dnenov · 2025-09-26T15:50:41Z

@dnenov so from what I understand, you just renamed some png files, and that fixed the issue; there are no code changes involved to get the icons to work with these new filenames, is that correct?

That is exactly right @aparajit-pratap . And I created a test to make sure no future resources will go beyond that limit.

dnenov · 2025-09-26T16:37:20Z

I think the file changes here will resolve the currently failing SelfServe process. The test is for posterity/futureproofing.

mjkkirschner · 2025-09-26T16:52:13Z

I have not reviewed in depth here but I wanted to point out that we’ve solved this same issue before for the docs files included in the docs browser - can we reuse the hashing implementation there instead of solving this twice in different ways(or manually)? Apologies if that code is already being leveraged.

dnenov · 2025-09-26T17:06:18Z

I have not reviewed in depth here but I wanted to point out that we’ve solved this same issue before for the docs files included in the docs browser - can we reuse the hashing implementation there instead of solving this twice in different ways(or manually)? Apologies if that code is already being leveraged.

Thank you for the suggestion @mjkkirschner ! Can you think of a PR, or the implementation in code, or the person that worked on it so I can follow up with them?

dnenov · 2025-09-26T18:24:04Z

I have not reviewed in depth here but I wanted to point out that we’ve solved this same issue before for the docs files included in the docs browser - can we reuse the hashing implementation there instead of solving this twice in different ways(or manually)? Apologies if that code is already being leveraged.

@RobertGlobant20 pointed me to the resource! Thanks again!!

- added a perpetually [IGNORE] test that contains the renaming functionality - reusing the existing Dynamo.Utilities.Hash.GetHashFilenameFromString - follows logging patterns based on NodeDocumentationMarkdownGenerator

…ng-path-file-fix

aparajit-pratap · 2025-09-29T15:50:56Z

src/Libraries/GeometryUIWpf/resource_rename_log.txt

Is this just a change log for future reference?

Yes, just so there is a trace of what hash names correspond to what methods. Of course, this information is somewhat redundand, as we can see which hash corresponds to what method right in the resx file (sorry for the formatting): <data name="Autodesk.DesignScript.Geometry.CoordinateSystem.ByOriginVectors.Point-Vector-Vector-Vector.Small" type="System.Resources.ResXFileRef, System.Windows.Forms"><value>..\..\Resources\ProtoGeometry\SmallIcons\AAKZVHCLWTXU5RUM5FFYOV63E2FFR2WTBC3X7N67EPUEO4HPFXFQ.png;System.Byte[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value> </data>

aparajit-pratap · 2025-09-29T15:52:44Z

src/Resources/ProtoGeometry/LargeIcons/JZO7MZ3Q42MELTSJ47532LUXA5JA6WWBO6BCTL4WTTQ35APVC5HA.png

I thought in your PR description, you mentioned that we are keeping only one copy of the png's for all Tspline nodes as they're all the same, did I understand that correctly?

I changed that when we move to the hashed names. Now we have a unique hash key for each unique file.

aparajit-pratap · 2025-09-29T15:54:53Z

...lIcons/Autodesk.DesignScript.Geometry.CoordinateSystem.Transform.CoordinateSystem2.Small.png

Are you using the hash names for the png's here? It looks like you're truncating the parameter names and using numbers to distinguish between overloads in this case?

We are using the new hashed png names from now on. We are no-longer truncating the parameters from the name. It is exactly as written in the log file: renamed Autodesk.DesignScript.Geometry.CoordinateSystem.ByOriginVectors.Point-Vector-Vector-Vector.Large: KSOB3IWYSUML6WJZTWA5LCRHIQV32SFCCGUANVBEKJLC7XCJ4PVA

zeusongit · 2025-09-29T17:26:12Z

The build does pass, https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/18445/
the failing test is flaky

resolve long file paths

2785e13

- created test to cover all resource file paths and prompts the long ones ( > 260 characters) - manually resolved the violating files

github-actions bot reviewed Sep 25, 2025

View reviewed changes

dnenov commented Sep 25, 2025

View reviewed changes

dnenov requested a review from zeusongit September 25, 2025 11:43

QilongTang requested review from a team, Copilot and saintentropy September 25, 2025 13:56

Copilot AI reviewed Sep 25, 2025

View reviewed changes

aparajit-pratap reviewed Sep 25, 2025

View reviewed changes

...y/LargeIcons/Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.FlattenVertices.Large.png Show resolved Hide resolved

aparajit-pratap reviewed Sep 25, 2025

View reviewed changes

test update

d605bf4

dnenov added 3 commits September 26, 2025 19:53

Revert file path shortening but keep ResourcePathLengthTests.cs

0b92361

fix as a test

9537073

- added a perpetually [IGNORE] test that contains the renaming functionality - reusing the existing Dynamo.Utilities.Hash.GetHashFilenameFromString - follows logging patterns based on NodeDocumentationMarkdownGenerator

Merge remote-tracking branch 'upstream/master' into DYN-9196-image-lo…

4daa38a

…ng-path-file-fix

dnenov marked this pull request as draft September 26, 2025 19:43

dnenov marked this pull request as ready for review September 29, 2025 14:49

Merge branch 'master' into DYN-9196-image-long-path-file-fix

03b5641

aparajit-pratap reviewed Sep 29, 2025

View reviewed changes

aparajit-pratap approved these changes Sep 30, 2025

View reviewed changes

aparajit-pratap merged commit 9e688e4 into DynamoDS:master Sep 30, 2025
26 of 29 checks passed

		// Calculate estimated server path length
		var serverPathLength = ESTIMATED_SERVER_PREFIX_LENGTH + relativePath.Length;

DYN-9196:net10-migration-resolve long file paths #16520

DYN-9196:net10-migration-resolve long file paths #16520

Uh oh!

Conversation

dnenov commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Release Notes

Reviewers

FYIs

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QilongTang commented Sep 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

dnenov commented Sep 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnenov Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aparajit-pratap left a comment

Choose a reason for hiding this comment

Uh oh!

dnenov commented Sep 26, 2025

Uh oh!

dnenov commented Sep 26, 2025

Uh oh!

mjkkirschner commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnenov commented Sep 26, 2025

Uh oh!

dnenov commented Sep 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zeusongit commented Sep 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dnenov commented Sep 25, 2025 •

edited

Loading

dnenov Sep 26, 2025 •

edited

Loading

mjkkirschner commented Sep 26, 2025 •

edited

Loading