Skip to content

DYN-9387: Take Panel Nodes out of experimental #16518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnpierson merged 8 commits into from
Oct 2, 2025
Merged

DYN-9387: Take Panel Nodes out of experimental #16518

johnpierson merged 8 commits into from
Oct 2, 2025

Conversation

@kalunkuo
Copy link
Contributor

@kalunkuo kalunkuo commented Sep 24, 2025 •
edited
Loading

Purpose

This PR takes Panel Nodes out of experimental.

Key changes:

PanelSurface

  • Removed PanelSurface from InitialExperimentalLib_Namespaces collection
  • Removed Panel namespace migration code in PreferenceSettings.Load()
  • Removed Panel experimental toggle from Preferences UI (PreferencesView.xaml)
  • Removed EnablePanelingIsChecked property and related tooltip handling
  • Panel nodes are now available as regular (non-experimental) nodes in the library

TSpline

  • Remove TSpline from experimental expander

Experimental expander

  • Hide experimental expander for future feature proofing
Screenshot 2025-09-24 at 1 44 10 PM Screenshot 2025-09-24 at 1 44 25 PM

Declarations

Check these if you believe they are true

Release Notes

Panel Surface nodes have been removed from experimental status and are now permanently available in the Geometry library.

Reviewers

@DynamoDS/synapse

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@kalunkuo kalunkuo requested review from a team and Copilot September 24, 2025 17:52
github-actions[bot]
github-actions bot reviewed Sep 24, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9387

Copilot AI reviewed Sep 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Panel nodes from experimental status, making them available as regular nodes in the Dynamo library. The change involves cleaning up all Panel-related experimental infrastructure that was previously used to toggle their visibility.

  • Removed Panel namespace from experimental collection
  • Removed Panel-specific UI toggle and related properties from preferences
  • Removed Panel namespace migration code for backwards compatibility

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
PreferencesView.xaml Removed Panel toggle UI elements from preferences window
PreferencesViewModel.cs Removed EnablePanelingIsChecked property and tooltip handling
PreferenceSettings.cs Removed Panel from experimental namespaces and migration logic

@QilongTang QilongTang requested a review from a team September 25, 2025 13:36
@zeusongit
Copy link
Contributor

zeusongit commented Sep 25, 2025

With panel nodes now OOTB, the experimental expander can be removed/hidden IMO, unless there is something else planned to be added. What do you think? @achintyabhat @mjkkirschner @aparajit-pratap

@kalunkuo
Copy link
Contributor Author

kalunkuo commented Sep 25, 2025

Oh I also noticed TSpline is still in experimental as well, it's hidden for now. I don't know if there is a task for it, should I also remove it?

PreferenceViewModel.cs

        /// <summary>
        /// Controls if the TSpline nodes experiment toggle is visible from feature flag
        /// TODO: remove this public property in Dynamo 4.0 and archive the feature flag
        /// </summary>
        public bool IsTSplineNodesExperimentToggleVisible
        {
            get
            {
                return false;
            }
        }

PreferencesView.xaml

PreferenceSettings.cs

aparajit-pratap
aparajit-pratap reviewed Sep 26, 2025
View reviewed changes
aparajit-pratap
aparajit-pratap reviewed Sep 26, 2025
View reviewed changes
aparajit-pratap
aparajit-pratap reviewed Sep 26, 2025
View reviewed changes
@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Sep 26, 2025

Oh I also noticed TSpline is still in experimental as well, it's hidden for now. I don't know if there is a task for it, should I also remove it?

PreferenceViewModel.cs

        /// <summary>
        /// Controls if the TSpline nodes experiment toggle is visible from feature flag
        /// TODO: remove this public property in Dynamo 4.0 and archive the feature flag
        /// </summary>
        public bool IsTSplineNodesExperimentToggleVisible
        {
            get
            {
                return false;
            }
        }

PreferencesView.xaml

PreferenceSettings.cs

I would remove it. Seems like dead code.

@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Sep 26, 2025

With panel nodes now OOTB, the experimental expander can be removed/hidden IMO, unless there is something else planned to be added. What do you think? @achintyabhat @mjkkirschner @aparajit-pratap

I agree, we should at the most hide it from the UI. I would keep the UI and basic infrastructure around for future proofing for features that may come in the future that we may wish to treat in the same way - i.e., an initial experimental baking period.

Copilot AI reviewed Sep 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

johnpierson
johnpierson approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@johnpierson johnpierson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and this all lgtm

@johnpierson johnpierson merged commit d7fda6d into DynamoDS:master Oct 2, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Copilot code review Copilot Copilot left review comments

@johnpierson johnpierson johnpierson approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

@reddyashish reddyashish Awaiting requested review from reddyashish

@jasonstratton jasonstratton Awaiting requested review from jasonstratton

@aparajit-pratap aparajit-pratap Awaiting requested review from aparajit-pratap

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kalunkuo @zeusongit @aparajit-pratap @johnpierson