DYN-9348 Revit Package Path Fix #16460

RobertGlobant20 · 2025-08-13T19:27:55Z

Purpose

Considering that we are using DynamoCore 3.6.0 and DynamoRevit 3.4.0, previously when installing a package in Dynamo for Revit was installing the package in the path created using DynamoCore version (e.g. C:\Users\user\AppData\Roaming\Dynamo\Dynamo Revit\3.6) but after this change now is using the DynamoRevit version path (e.g. C:\Users\user\AppData\Roaming\Dynamo\Dynamo Revit\3.4\packages).

Note: This fix is only for Dynamo for Revit

Declarations

Check these if you believe they are true

Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB
This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Changing the package path installation for Dynamo Revit to use the DynamoRevit version (instead of DynamoCore version)

Reviewers

@QilongTang

FYIs

@zeusongit

Considering that we are using DynamoCore 3.6.0 and DynamoRevit 3.4.0 previously when installing a package in Dynamo for Revit was installing the package in the path created using DynamoCore version (e.g. C:\Users\user\AppData\Roaming\Dynamo\Dynamo Revit\3.6) but after this change now is using the DynamoRevit version path (e.g. C:\Users\user\AppData\Roaming\Dynamo\Dynamo Revit\3.4\packages).

github-actions

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9348

Copilot

Pull Request Overview

This PR fixes the package installation path for Dynamo Revit to use the correct DynamoRevit version instead of the DynamoCore version. The change ensures packages are installed in the appropriate version-specific directory (e.g., 3.4 instead of 3.6).

Introduces a static HostInfo class to store and access the host version globally
Modifies the PathManager to use the host version for package path construction in Dynamo Revit scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/DynamoCore/Models/DynamoModel.cs	Adds static HostInfo class and populates it with host version during model initialization
src/DynamoCore/Configuration/PathManager.cs	Updates PathManager to use HostInfo.HostVersion for package path calculation when available

Copilot · 2025-08-13T19:28:34Z

src/DynamoCore/Models/DynamoModel.cs

+    /// Contains the HostVersion inside a static class so that it can be accessed in other parts of the code without creating an instance.
+    /// </summary>
+    public static class HostInfo
+    {


The HostVersion field should have XML documentation explaining its purpose, when it's set, and what it represents in different hosting scenarios.

Suggested change

{

{

/// <summary>

/// Represents the version of the host application in which Dynamo is running.

/// This field is set during Dynamo initialization by the host (e.g., Revit, Civil 3D, or standalone).

/// In different hosting scenarios, this value reflects the version of the host product:

/// - In Dynamo Revit, it is set to the Revit version (e.g., 2025.2.0).

/// - In standalone Dynamo, it may be set to the Dynamo version itself.

/// Consumers should check this value to determine host-specific behaviors or compatibility.

/// </summary>

Copilot · 2025-08-13T19:28:34Z

src/DynamoCore/Configuration/PathManager.cs


            BuildHostDirectories(pathManagerParams.HostPath);

+            //In the case of Dynamo for Revit HostInfo.HostVersion will contain the DynamoRevit version so we will use this values for installing packages in the right location


Grammar error: 'this values' should be 'these values' in the comment.

Suggested change

//In the case of Dynamo for Revit HostInfo.HostVersion will contain the DynamoRevit version so we will use this values for installing packages in the right location

//In the case of Dynamo for Revit HostInfo.HostVersion will contain the DynamoRevit version so we will use these values for installing packages in the right location

src/DynamoCore/Configuration/PathManager.cs

RobertGlobant20 · 2025-08-13T19:29:34Z

This is a GIF showing that now is installing the package in the DynamoRevit version and a GIF showing that after re-opening Dynamo is loading the package from the right path and showing the installation path updated.

RobertGlobant20 · 2025-08-13T19:31:02Z

This is a GIF showing that when installing the package in DynamoSandbox (the same path remains) is using the 3.6 path.

QilongTang · 2025-08-13T20:42:40Z

src/DynamoCore/Configuration/PathManager.cs

+            if (HostInfo.HostVersion != null)
+            {
+                pathManagerParams.MajorFileVersion = HostInfo.HostVersion.Major;
+                pathManagerParams.MinorFileVersion = HostInfo.HostVersion.Minor;


So I guess these are considered overwriting of PathManager default behavior right? Would you point me, where are these two params used?

If with default behavior you are talking about DynamoSandbox, I already tested and is installing the packages in the right path (e.g. if DynamoCore is 3.6.0 then is installed in C:\Users\user\AppData\Roaming\Dynamo\Dynamo Core\3.6).

We are using majorFileVersion and minorFileVersion inside PathManager in the next code:

Dynamo/src/DynamoCore/Configuration/PathManager.cs

Line 693 in 8c7ddef

return Path.Combine(folder,

And is used for building the userDataDir that later is used for building the packages dir in the next code:

Dynamo/src/DynamoCore/Configuration/PathManager.cs

Line 609 in 8c7ddef

commonPackages = Path.Combine(commonDataDir, PackagesDirectoryName);

Also found that for creating the PathManager instance we are using a lazy loading Singleton with parameters in the constructor but we are passing the parameters only in test mode so not used in Revit, then the only way that I found to get the Version was by using a static class.

Also not sure how we are going to test this change due that I had to use Dynamo RC3.6.0_master branch with DynamoRevit master branch to test in Revit Preview Release 2027, if I use the latest Dynamo master branch (the base of my branch) then Dynamo is not opening in Revit.

Updating comments suggested by Copilot

RobertGlobant20 · 2025-08-22T00:24:32Z

@QilongTang @zeusongit
Do you have any more comment about this PR?

reddyashish · 2025-08-27T15:08:34Z

src/DynamoCore/Models/DynamoModel.cs

+    /// <summary>
+    /// Contains the HostVersion inside a static class so that it can be accessed in other parts of the code without creating an instance.
+    /// </summary>
+    public static class HostInfo


For host name/version, we should use the one in DynamoModel.HostAnalyticsInfo instead of exposing it directly on the model. Any reason?

@reddyashish the reason is due that we need to use the host name/version inside the PathManager class (which is a lazy loading Singleton), then PathManager doesn't have access to DynamoModel.HostAnalyticsInfo and the only way that I found for accessing the host name/version in the singleton (and avoiding altering the structure) was by using a public static class.

zeusongit · 2025-09-23T20:24:53Z

@QilongTang Any update from the D4R side that will affect this? Can we merge and test?

QilongTang · 2025-09-24T02:24:14Z

@QilongTang Any update from the D4R side that will affect this? Can we merge and test?

Sorry I should comment way earlier, I am a bit skeptical the public static class approach under DynamoModel is the best approach here given it would duplicate info which already exists.. @RobertGlobant20 Would you brainstorm with copilot about other alternatives? Apologize for the late comment

RobertGlobant20 · 2025-09-24T20:30:36Z

@QilongTang Any update from the D4R side that will affect this? Can we merge and test?

Sorry I should comment way earlier, I am a bit skeptical the public static class approach under DynamoModel is the best approach here given it would duplicate info which already exists.. @RobertGlobant20 Would you brainstorm with copilot about other alternatives? Apologize for the late comment

GitHub Copilot is suggesting the next alternatives:

Set Before First Access (Recommended)
Pass via IPathResolver
Modify the Lazy Initialization Logic
Set Static Properties Before First Use
Recreate the Singleton (Not Recommended)

I will check the options 1 and 2 since are the recommended, 4 is similar like I implemented

RobertGlobant20 · 2025-10-10T21:10:22Z

closed due that we are already working in a different implementation, see #16528

RobertGlobant20 requested review from QilongTang and Copilot August 13, 2025 19:27

github-actions bot reviewed Aug 13, 2025

View reviewed changes

Copilot AI reviewed Aug 13, 2025

View reviewed changes

QilongTang reviewed Aug 13, 2025

View reviewed changes

DYN-9348 Revit Package Path Code Review

9abebd0

Updating comments suggested by Copilot

RobertGlobant20 requested a review from zeusongit August 22, 2025 00:22

reddyashish reviewed Aug 27, 2025

View reviewed changes

zeusongit approved these changes Sep 23, 2025

View reviewed changes

benglin mentioned this pull request Oct 9, 2025

DYN-9348 Integrator PackagePath following Integration version #16528

Merged

3 tasks

RobertGlobant20 closed this Oct 10, 2025

-    {
+    {
+        /// <summary>
+        /// Represents the version of the host application in which Dynamo is running.
+        /// This field is set during Dynamo initialization by the host (e.g., Revit, Civil 3D, or standalone).
+        /// In different hosting scenarios, this value reflects the version of the host product:
+        /// - In Dynamo Revit, it is set to the Revit version (e.g., 2025.2.0).
+        /// - In standalone Dynamo, it may be set to the Dynamo version itself.
+        /// Consumers should check this value to determine host-specific behaviors or compatibility.
+        /// </summary>


		BuildHostDirectories(pathManagerParams.HostPath);

		//In the case of Dynamo for Revit HostInfo.HostVersion will contain the DynamoRevit version so we will use this values for installing packages in the right location

DYN-9348 Revit Package Path Fix #16460

DYN-9348 Revit Package Path Fix #16460

Uh oh!

Conversation

RobertGlobant20 commented Aug 13, 2025

Purpose

Declarations

Release Notes

Reviewers

FYIs

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RobertGlobant20 commented Aug 13, 2025

Uh oh!

RobertGlobant20 commented Aug 13, 2025

Uh oh!

QilongTang Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

RobertGlobant20 Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

RobertGlobant20 commented Aug 22, 2025

Uh oh!

reddyashish Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

RobertGlobant20 Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

zeusongit commented Sep 23, 2025

Uh oh!

QilongTang commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RobertGlobant20 commented Sep 24, 2025

Uh oh!

RobertGlobant20 commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

QilongTang commented Sep 24, 2025 •

edited

Loading