DYN-9191: Fix test to work with the improved recent files logic #16411
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9191
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a test related to recent files functionality by updating a test configuration file to reference a newly created test file. The change replaces a hardcoded absolute file path with a relative path to a proper test file.
- Updates the recent files test configuration to use a relative path instead of an absolute path
- Adds a new Dynamo test file containing a basic addition workflow for testing recent files logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/settings/RecentFilesTest.dyn | New test file containing a simple Dynamo graph with basic addition functionality |
| test/settings/DynamoSettings-NewSettings.xml | Updates recent files path reference from absolute to relative path pointing to the new test file |
Comments suppressed due to low confidence (1)
test/settings/DynamoSettings-NewSettings.xml:43
- The relative path uses hardcoded directory traversal that may be fragile across different test environments. Consider using a more robust path resolution mechanism or environment-relative path.
<string>..\..\..\test\settings\RecentFilesTest.dyn</string>
|
removing milestone, as cherry pick not needed, already merged the test fix to the cherry pick PR of the parent issue here: #16412 |
|
The test will have to be fixed on 3.6 branch too right? |
Yes but is part of the main cherry pick PR so we do not need a separate PR for this test fix: #16412 |
|
Can you check TestImportCopySettings test, it is still failing on other PR's |
Yes fixed and passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/18257/ |
Purpose
Fix test to work with the improved recent files logic
Since we do not add invalid paths to recent files anymore, the test was failing as it adds a non-existent file. Updated the test to add a valid file now
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix test to work with the improved recent files logic
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of