DYN-9170 : close node autocomplete when certain commands are started #16384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9170
BogdanZavu
commented
Jul 15, 2025
| ViewModel.OnNodeAutoCompleteWindowClosed(); | ||
| Hide(); | ||
| { | ||
| if (IsVisible) //when window is already hidden it means unsubscribe was already performed |
Contributor
Author
There was a problem hiding this comment.
This particular change is not related to the PR subject but it is small/harmless and did not want to create another task for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want to close the node autocomplete bar if it is visible when other commands are invoked.
Currently we do this if the user wants to create a node, connect a node or delete node(s).
Moving forward we can add other commands as well.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Hide autocomplete marker on far zoom out
Reviewers
@DynamoDS/synapse