[DYN-8893] - Double click on group to add cbn #16383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8893
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores double-click functionality on annotation groups to add a CodeBlockNode and adds a corresponding unit test.
- Subscribes to
PreviewMouseDoubleClickinAnnotationView.xaml.csand implementsOnAnnotationDoubleClicklogic. - Adds a test
DoubleClickOnGroupAddsCodeBlockNodeto verify the new behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/DynamoCoreWpfTests/AnnotationViewTests.cs | Added test for double-click on group adding a CBN. |
| src/DynamoCoreWpf/Views/Core/AnnotationView.xaml.cs | Subscribes/unsubscribes double-click event and handler. |
Comments suppressed due to low confidence (1)
test/DynamoCoreWpfTests/AnnotationViewTests.cs:184
- After verifying the node count, add an assertion to check that the newly added node is of type
CodeBlockNodeModel, ensuring the correct node type was created.
Assert.AreEqual(3, group1.Nodes.Count(), "Expected group to have 3 nodes after double click.");
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
reddyashish
approved these changes
Jul 15, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Small PR related to DYN-8893 and this tread.
This PR restores the changes to AnnotationView.xaml.cs that allow double-clicking on a group to add a CodeBlockNode to it. These changes were previously submitted in #16334 but are not present in the current master branch.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Double-clicking on a group adds a code block node to it.
Reviewers
@DynamoDS/eidos
@jasonstratton
@zeusongit
FYIs
@dnenov
@achintyabhat