Skip to content

Conversation

@chubakueno
Copy link
Contributor

Purpose

Hide autocomplete marker on far zoom out

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Hide autocomplete marker on far zoom out

Reviewers

@DynamoDS/synapse

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9159

Copy link
Member

@johnpierson johnpierson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! This works well.

@johnpierson johnpierson requested a review from Copilot July 15, 2025 13:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new value converter to hide UI markers when zoomed out past a threshold and wires it into both InPorts and OutPorts controls.

  • Introduces ZoomToInverseVisibilityCollapsedConverter for collapsing elements at low zoom levels
  • Registers the converter in OutPorts.xaml.cs and InPorts.xaml.cs to bind marker Visibility to the workspace zoom
  • Updates PublicAPI.Unshipped.txt to expose the new converter in the public API

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/DynamoCoreWpf/UI/Converters.cs Added ZoomToInverseVisibilityCollapsedConverter with Convert/ConvertBack
src/DynamoCoreWpf/PublicAPI.Unshipped.txt Exposed ZoomToInverseVisibilityCollapsedConverter in the public API
src/DynamoCoreWpf/Controls/OutPorts.xaml.cs Bound NodeAutoCompleteHover.Visibility to zoom via the new converter
src/DynamoCoreWpf/Controls/InPorts.xaml.cs Bound NodeAutoCompleteHover.Visibility to zoom via the new converter

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@johnpierson johnpierson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chubakueno chubakueno merged commit dd33466 into DynamoDS:master Jul 15, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants