-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-9159: Hide autocomplete marker on far zoom out #16382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9159
johnpierson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! This works well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new value converter to hide UI markers when zoomed out past a threshold and wires it into both InPorts and OutPorts controls.
- Introduces ZoomToInverseVisibilityCollapsedConverter for collapsing elements at low zoom levels
- Registers the converter in OutPorts.xaml.cs and InPorts.xaml.cs to bind marker Visibility to the workspace zoom
- Updates PublicAPI.Unshipped.txt to expose the new converter in the public API
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/DynamoCoreWpf/UI/Converters.cs | Added ZoomToInverseVisibilityCollapsedConverter with Convert/ConvertBack |
| src/DynamoCoreWpf/PublicAPI.Unshipped.txt | Exposed ZoomToInverseVisibilityCollapsedConverter in the public API |
| src/DynamoCoreWpf/Controls/OutPorts.xaml.cs | Bound NodeAutoCompleteHover.Visibility to zoom via the new converter |
| src/DynamoCoreWpf/Controls/InPorts.xaml.cs | Bound NodeAutoCompleteHover.Visibility to zoom via the new converter |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
johnpierson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Purpose
Hide autocomplete marker on far zoom out
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Hide autocomplete marker on far zoom out
Reviewers
@DynamoDS/synapse
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of