Skip to content

Conversation

@BogdanZavu
Copy link
Contributor

@BogdanZavu BogdanZavu commented Jul 14, 2025

Purpose

Avoid marking the graph with unsaved changes while in transient state.
Avoid requesting a graph run while in transient state.
The graph will be marked with unsaved changes only when confirming a cluster ( or a single node ) and a single run will be performed in both automatic and manual mode.

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Optimize graph execution in the context of node autocomplete new experience.

Reviewers

@DynamoDS/synapse

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9176

@johnpierson
Copy link
Member

Is there a different ticket number? This seems to point to something else

Copy link
Member

@johnpierson johnpierson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just if we can reference the correct jira ticket or make one if needed

@BogdanZavu
Copy link
Contributor Author

lgtm, just if we can reference the correct jira ticket or make one if needed

Ok, I created one. I'm usually using magical numbers 7777,8888,9999 when a Jira is not available/created yet :).

@BogdanZavu BogdanZavu changed the title DYN-8888 : optimize graph execution for dna DYN-9176 : optimize graph execution for dna Jul 14, 2025
@github-actions github-actions bot changed the title DYN-9176 : optimize graph execution for dna 8888: DYN-9176 : optimize graph execution for dna Jul 14, 2025
@BogdanZavu BogdanZavu changed the title 8888: DYN-9176 : optimize graph execution for dna DYN-9176 : optimize graph execution for dna Jul 14, 2025
@github-actions github-actions bot changed the title DYN-9176 : optimize graph execution for dna 8888: DYN-9176 : optimize graph execution for dna Jul 14, 2025
@BogdanZavu BogdanZavu changed the title 8888: DYN-9176 : optimize graph execution for dna DYN-9176 : optimize graph execution for dna Jul 14, 2025
@github-actions github-actions bot changed the title DYN-9176 : optimize graph execution for dna 8888: DYN-9176 : optimize graph execution for dna Jul 14, 2025
@BogdanZavu BogdanZavu merged commit 76dd8a9 into DynamoDS:master Jul 14, 2025
38 of 41 checks passed
@BogdanZavu BogdanZavu deleted the DYN-8888 branch July 14, 2025 16:42
@BogdanZavu BogdanZavu changed the title 8888: DYN-9176 : optimize graph execution for dna DYN-9176 : optimize graph execution for dna Jul 14, 2025
@github-actions github-actions bot changed the title DYN-9176 : optimize graph execution for dna 8888: DYN-9176 : optimize graph execution for dna Jul 14, 2025
@johnpierson johnpierson changed the title 8888: DYN-9176 : optimize graph execution for dna DYN-9176 : optimize graph execution for dna Jul 14, 2025
@github-actions github-actions bot changed the title DYN-9176 : optimize graph execution for dna 8888: DYN-9176 : optimize graph execution for dna Jul 14, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants