Skip to content

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Jun 23, 2025

Purpose

Allow newline support for the Graph Properties Description field. As per https://jira.autodesk.com/browse/DYN-8658

image

DynamoSandbox_c0tRnFsnFn

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

  • allowed new line support for Graph Properties Description field
  • added fixed height and vertical scroll visibility auto to correctly handle large texts

Reviewers

@zeusongit
@reddyashish

FYIs

@jasonstratton
@achintyabhat

- allowed new line support for Graph Properties Description field
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8658

@zeusongit zeusongit requested a review from Copilot June 24, 2025 01:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enables multi-line input in the Graph Properties Description field by allowing users to enter newline characters.

  • Added AcceptsReturn="True" to the description TextBox
  • Ensured text wraps within the control
Comments suppressed due to low confidence (1)

src/GraphMetadataViewExtension/GraphMetadataView.xaml:148

  • There’s no test covering the new multiline behavior. Consider adding a UI or integration test that verifies entering, displaying, and saving newline characters in the description field to prevent regressions.
                         AcceptsReturn="True" />

- vertical scroll will now appear if the text height exceeds the fixed height of the text box
@dnenov dnenov changed the title DYN-8658:allowed newline support DYN-8658: allowed newline support Jun 25, 2025
@dnenov dnenov requested a review from jasonstratton June 25, 2025 15:40
@zeusongit zeusongit merged commit eb2f96a into DynamoDS:master Jun 25, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants