[DYN-7845] Hide input and output ports from collapsed groups #16302
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7845
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the collapsed group functionality by adding new preferences and UI controls to hide optional input ports and unconnected output ports, and to automatically apply minimal dimensions when groups are collapsed.
- New toggle buttons and layout rows in the preferences UI allow manual control over port visibility per group.
- Annotation views and view models now recalculate group boundaries and proxy port positions based on these new settings.
- Relevant configuration, public API, and resource entries have been updated to support this new functionality.
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml | Added new rows and controls for managing port visibility and collapsed group size. |
| src/DynamoCoreWpf/Views/Core/AnnotationView.xaml.cs | Updated event handling and boundary recalculation logic for collapsed groups. |
| src/DynamoCoreWpf/Views/Core/AnnotationView.xaml | Added a new toggle button template and layout updates for port controls. |
| src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs | Introduced new preference properties and updated property change notifications. |
| src/DynamoCoreWpf/ViewModels/Core/AnnotationViewModel.cs | Refactored proxy port creation and port repositioning logic for collapsed scenarios. |
| src/DynamoCore/Graph/Annotations/AnnotationModel.cs | Updated boundary calculations and added new properties for port collapse settings. |
| src/DynamoCore/Configuration/PreferenceSettings.cs & IPreferences.cs | Included new settings to persist port collapse and minimal size preferences. |
| Others (Resources, PublicAPI, WorkspaceModel, etc.) | Extended API and resource strings to accommodate the new functionality. |
Files not reviewed (1)
- src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (2)
src/DynamoCore/Graph/Workspaces/WorkspaceModel.cs:148
- [nitpick] The field 'hasToggledOptionalInPorts' uses lower-case naming which is inconsistent with standard PascalCase conventions. Consider renaming it to 'HasToggledOptionalInPorts' for consistency.
public bool hasToggledOptionalInPorts;
jasonstratton
left a comment
There was a problem hiding this comment.
Lots of file changes. Most of them appear straight forward. There is some complexity in the AnnotationModel and AnnotationView, which is probably expected. :D
I believe I was able to follow the changes in the view. If I could do that, it's probably good. :D
So I think it LGTM, thanks.
|
Thanks for the feedback! I've refactored UpdateBoundaryFromSelection() and added clearer comments as suggested. Let me know if anything still looks off. |
…collapsed-groups_250616
…ups_250616' of https://github.com/ivaylo-matov/Dynamo into DYN-7845-Hide-input-and-output-ports-from-collapsed-groups_250616
|
|
…DYN-7845-Hide-input-and-output-ports-from-collapsed-groups_250616
…collapsed-groups_250616
…ups_250616' of https://github.com/ivaylo-matov/Dynamo into DYN-7845-Hide-input-and-output-ports-from-collapsed-groups_250616
|
logic refactored following changes in #16252 |
|
@ivaylo-matov can you take a look at the failing tests? |
|
@zeusongit , the tests should pass now. |
|
I think the comments were addressed and if the tests are passing now (Although Dynamo DelfServe failed), I think my approval still stands. @ivaylo-matov , do you merge? Or do I? |
…collapsed-groups_250616
zeusongit
left a comment
There was a problem hiding this comment.
Resolved conflict between CodeBlockCollapsedPortVisualHeight and CBNProxyPortVisualHeight
CodeBlockCollapsedPortVisualHeight was introduced in #16300 but was not used anywhere, so I assume CBNProxyPortVisualHeight is the correct variable name.
…ut-and-output-ports-from-collapsed-groups_250616
…ut-and-output-ports-from-collapsed-groups_250616
Purpose
This PR aims to address DYN-7845.
New Preference Settings:
Port Toggles:
unconnected output ports are output ports with no outgoing connections.
Manual Overrides:
Please note that to calculate the minimal width of a collapsed group, the view waits until the ports have been rendered once, then reads their measured DesiredSize to compute the smallest area needed to fit all visible ports and toggles. This causes a second render pass for the group .Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
New preferences and group UI controls let users hide optional input and unconnected output ports by default when a group is collapsed. Users can also manually toggle port visibility and keep custom collapsed group sizes, overriding the default settings.
Reviewers
@DynamoDS/eidos
@jasonstratton
FYIs
@achintyabhat
@dnenov