DYN-8302: Optimizing loading of icons and preview bubble. #16285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8302
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes icon rendering by setting bitmap scaling to low quality for node visuals and improves performance of preview bubbles by debouncing their initialization on mouse events. It also introduces toggling of panning mode via the middle mouse button in the workspace view.
- Apply low-quality bitmap scaling to default and dynamic node icons to reduce rendering overhead.
- Debounce preview bubble creation on mouse enter and cancel on leave to minimize unnecessary UI instantiation.
- Add middle-button handlers in
WorkspaceViewto toggle pan mode on press and release.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml.cs | Added middle-button pan toggling logic in mouse down and release handlers. |
| src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs | Set low-quality bitmap scaling on multiple icons and implemented debounced preview bubble logic with initialization and cancellation methods. |
| src/DynamoCoreWpf/ViewModels/Core/WorkspaceViewModel.cs | Introduced DelayNodePreviewControl debouncer utility and wired up disposal. |
Comments suppressed due to low confidence (5)
src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs:1561
- [nitpick] Inconsistent use of
viewModel(field) andViewModel(property) can be confusing. Consider standardizing on theViewModelproperty throughout.
viewModel.WorkspaceViewModel.DelayNodePreviewControl.Debounce(300, DelayPreviewControlAction);
src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs:1561
- The new debouncing logic for preview bubbles isn't covered by existing tests. Consider adding unit or integration tests to verify timing, invocation, and cancellation behaviors.
viewModel.WorkspaceViewModel.DelayNodePreviewControl.Debounce(300, DelayPreviewControlAction);
src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml.cs:905
- Using
e.MiddleButtonto detect which button was pressed may not reliably capture the middle-button click; consider checkinge.ChangedButton == MouseButton.Middlefor clarity and correctness.
if (!ViewModel.IsPanning && e.MiddleButton == MouseButtonState.Pressed)
src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs:2144
- The previous check for
viewModel.IsTransientwas removed, so transient nodes may now show a preview unexpectedly. Re-add theviewModel.IsTransientcondition to disable preview during transient state.
ViewModel.WorkspaceViewModel.IsPanning;
src/DynamoCoreWpf/ViewModels/Core/WorkspaceViewModel.cs:592
- Initializing
ActionDebouncerwith a null callback may lead to null-reference errors if used before assigning a valid action. Consider providing a no-op default or delaying the instantiation until a callback is known.
= new Wpf.Utilities.ActionDebouncer(null);
zeusongit
approved these changes
Jun 30, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-8302
https://jira.autodesk.com/browse/DYN-8306
Based out of changes from #15763 and #15823.
Icon freezing was already implemented in Node to Code PR. For some generic icons, bitmap-scalingmode has been set to low quality.
For preview bubble, we will be initializing the preview control only if the mouse stays on the node for a short time. It also helps when users are navigating large graphs, preview control won't be initialized for the passing nodes.
All tests passing now.
Open workspace timings
Entry Christmas : before 16-17 secs, after this change around 15 secs.
500 List nodes: noticing a difference of around 3 secs differential.
Autodesk-Mars : before 30-35 secs, after this change around 30 secs.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Optimizing loading of icons and preview bubble.
Reviewers
@DynamoDS/eidos