DYN-8564: run autocomplete search in background thread #16265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8564
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the ML autocomplete call to a background thread and adds a loading state flag to toggle between a spinner stripe and the search results UI.
- Introduces a
ResultsLoadedproperty and wraps the ML request inTask.Run - Adds error handling and marshals UI updates via the dispatcher
- Updates the XAML to show a
LoadingAnimationStripeControlwhile results are loading
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs | Adds ResultsLoaded, moves ML call to a background thread, and dispatches UI updates |
| src/DynamoCoreWpf/Controls/NodeAutoCompleteSearchControl.xaml | Defines an inverse visibility converter and binds the spinner/control visibility to ResultsLoaded |
Comments suppressed due to low confidence (1)
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs:335
- [nitpick] The method name
UpdateUIWithRresultscontains a typo (Rresults). Consider renaming it toUpdateUIWithResultsfor clarity and consistency.
private void UpdateUIWithRresults(MLNodeAutoCompletionResponse MLresults)
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
BogdanZavu
reviewed
Jun 4, 2025
| internal bool IsOpen { get; set; } | ||
|
|
||
| private bool resultsLoaded; | ||
| public bool ResultsLoaded |
Contributor
There was a problem hiding this comment.
Looks like we need this to be public due to the binding. Let's add a comment an d also make it obsolete.
BogdanZavu
reviewed
Jun 4, 2025
BogdanZavu
approved these changes
Jun 4, 2025
Contributor
|
Made a few comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Run autocomplete search in background thread and hide search box with animation stripe.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Run autocomplete search in background thread and hide search box with animation stripe.
Reviewers
@BogdanZavu
@johnpierson
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of