DYN-8906 : introduce autocomplete search combo #16256
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8906
There was a problem hiding this comment.
Pull Request Overview
Adds an inline search box to the autocomplete combo and wires up filtering in the view model.
- Binds the combo’s ItemsSource to a filtered view and injects a TextBox as the search input.
- Implements
FilteredView,FilterLogic, and aSearchInputproperty in the ViewModel. - Updates the Modern theme’s ComboBox template and registers a new converter.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml | Swapped ItemsSource, added Font settings, and placed a TextBox in the ComboBox.Tag |
| src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs | Introduced FilteredView, FilterLogic, and SearchInput handling |
| src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml | Extended ComboBox popup template to render the search slot |
| src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml | Added NullToVisibiltyConverter resource |
Comments suppressed due to low confidence (1)
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs:200
- The new filtering logic in 'FilterLogic' and the SearchInput behavior lack unit tests—consider adding tests to verify filtering results across various inputs.
private bool FilterLogic(object item)
| if (FilteredView != null) | ||
| { | ||
| FilteredView.Refresh(); | ||
| } |
There was a problem hiding this comment.
After updating SearchInput, the ViewModel should raise PropertyChanged for 'SearchInput' to notify any bound consumers of its new value.
| } | |
| } | |
| RaisePropertyChanged(nameof(SearchInput)); |
|
Had to build the pipeline manually , results here |
Purpose
Add a search box inside the combo box of the autocomplete new experience.
It needs a little bit more work but we'll follow up on this or another pr.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
@DynamoDS/synapse
FYIs
@QilongTang