Skip to content

Conversation

@github-actions
Copy link

Cherry-pick of #16185 to RC3.5.1_master

Purpose

Fixing problem with the Data.OpenXMLImportExcel node sending the exception "Object reference not set to an instance of an object.".
Probably this error is based in how the excel spreadsheet was created (by some reason is counting empty rows as if they contains data but if you copy the info to a new excel sheet it works as expected) but basically the problem is that when the spreadsheet contains empty rows sometimes the Row.LastChild is null so the "Object reference not set to an instance of an object." exception is generated when trying to check any property inside the Cell instance. For fixing this problem I just added a validation that will skip the empty row if Row.LastChild is null.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixing problem with the Data.OpenXMLImportExcel node sending the exception "Object reference not set to an instance of an object.".

Reviewers

@zeusongit @DynamoDS/eidos

FYIs

@achintyabhat

@github-actions github-actions bot added this to the 3.5.1 milestone May 16, 2025
@github-actions github-actions bot requested a review from achintyabhat May 16, 2025 17:11
@github-actions github-actions bot mentioned this pull request May 16, 2025
9 tasks
@zeusongit
Copy link
Contributor

@zeusongit zeusongit merged commit 03e3d0b into RC3.5.1_master May 16, 2025
11 of 12 checks passed
@zeusongit zeusongit deleted the cherrypick-16185 branch May 16, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants