Skip to content

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Apr 30, 2025

Purpose

It was identified that Measure/Arrange override methods in InOutPortPanel consumed a lot of cycles when loading a graph, it was noted that the custom solution was implemented specifically for CBN nodes to align incremental ports (PR).
It was being triggered recursively for each port on each node irrespective of it's type. As a resolution in this PR the target style is made conditional, so we will use the InOutPortPanel based style only for CodeBlock nodes.

Results:

~83000 ms -> ~70000 ms (~16% faster)

(After left - Before right)
Screenshot 2025-04-30 at 6 03 31 PM

Profiled with 1024PointsByCoordinate nodes graph and tested with Manekin as well

(Still testing with more nodes)

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Use Panel based port size calculation only for CodeBlockNodes

Reviewers

@zeusongit zeusongit marked this pull request as ready for review April 30, 2025 21:30
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8802

@zeusongit zeusongit merged commit f651178 into DynamoDS:master May 5, 2025
27 checks passed
@zeusongit zeusongit removed the WIP label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants