Skip to content

DYN-8558 : transient node from the get go #16168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BogdanZavu merged 2 commits into from
Apr 25, 2025
Merged

DYN-8558 : transient node from the get go #16168

BogdanZavu merged 2 commits into from
Apr 25, 2025

Conversation

@BogdanZavu
Copy link
Contributor

@BogdanZavu BogdanZavu commented Apr 25, 2025 •
edited
Loading

Purpose

Create a transient node from the get go so that it will not execute when is added to the workspace.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@DynamoDS/synapse

github-actions[bot]
github-actions bot reviewed Apr 25, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8558

@johnpierson
Copy link
Member

johnpierson commented Apr 25, 2025 •
edited
Loading

What does this change do to people who already use the create node command without this overload?

Nevermind, I see it. :) Testing locally now.

@johnpierson
Copy link
Member

johnpierson commented Apr 25, 2025

This lgtm, one comment would be, can we make the nodes run after they are no longer transient. But only if the user is in automatic run mode?

@johnpierson
Copy link
Member

johnpierson commented Apr 25, 2025

did a fake edit on the file to retrigger tests 🙈

@johnpierson johnpierson self-requested a review April 25, 2025 15:17
johnpierson
johnpierson approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@johnpierson johnpierson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if we can get the graph to execute after the nodes are no longer transient (in the consolidateTransientNodes method) that would be awesome (could be another pr though).

@BogdanZavu
Copy link
Contributor Author

BogdanZavu commented Apr 25, 2025

This lgtm, one comment would be, can we make the nodes run after they are no longer transient. But only if the user is in automatic run mode?

Yes, will add that too.

@BogdanZavu BogdanZavu merged commit 5c263c9 into DynamoDS:master Apr 25, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@johnpierson johnpierson johnpierson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BogdanZavu @johnpierson @zavub