-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-8310 - speed up graph open by caching category getter #16151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8310
Curious why this doesn't have much performance impact in Dynamo UI? |
|
It would be great if you could drop that graph in https://git.autodesk.com/Dynamo/DynamoTestGraphs |
I should have been more clear with numbers. The mars graph v3 loads on my machine with no changes in ~1000ms (headless) The mars graph v3 loads with UI in 30000ms - so the small number of ms saved here just make no discernable difference - the time is dominated by UI rendering/xaml loading etc. |
Purpose
based on changes in:
#15834
simplifies these changes but retains 20 -25% performance improvement for headless graph load time. Note that this % does not improve load time of graphs in Dynamo UI significantly, but it will be valuable for headless use cases.
Assembly.Loadwhich internally caches if an assembly is already loaded - confirmed this is the case here:https://github.com/dotnet/runtime/blob/main/src/coreclr/vm/appdomain.cpp#L2554
I verified the 20% number using the mars v3 graph. (~700 nodes)
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
improve graph open time in headless contexts.