Skip to content

Conversation

@ivaylo-matov
Copy link
Contributor

Purpose

This PR addresses DYN-8055, which reports incorrect vertical placement of the port context menu popup.

The issue was caused by the incorrect original placement formula and not accounting for the top border used in custom nodes. This has now been resolved by adjusting the Y-offset calculation to include the height of the custom node’s top borders.

To keep layout logic consistent, the top border height has been added as a constant in NodeModel, similar to the existing HeaderHeight constant.

DYN-8055-Proposal_250415

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixed incorrect positioning of port context menus by updating the placement logic.

Reviewers

@reddyashish
@zeusongit

FYIs

@dnenov
@achintyabhat

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8055

@reddyashish reddyashish merged commit 35c0438 into DynamoDS:master Apr 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants