[DYN-7844] As a user, I want to freeze groups #15942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7844
zeusongit
approved these changes
Mar 18, 2025
Contributor
|
@ivaylo-matov some conflicts |
reddyashish
reviewed
Mar 18, 2025
| WorkspaceViewModel.DynamoViewModel.RaiseCanExecuteUndoRedo(); | ||
| WorkspaceViewModel.HasUnsavedChanges = true; | ||
|
|
||
| Analytics.TrackEvent(Actions.Preview, Categories.GroupOperations, newFrozenState.ToString()); |
Contributor
There was a problem hiding this comment.
I don't think we track analytics for freezing nodes, so this can be avoid for freezing groups as well.
Contributor
There was a problem hiding this comment.
We do have a Freeze Action, maybe use that instead of Preview
Contributor
Author
There was a problem hiding this comment.
Thank you, both. The analytics is now tracking Freeze.
reddyashish
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
PR aims to address DYN-7844.
Overview
This is a proposal for new functionality that allows users to freeze an entire group from the group's context menu. This action freezes all nodes inside the group, including those within nested groups. Additionally, users can individually freeze/unfreeze nodes within a frozen group.
Behavior :
I've assumed including nested groups is within the expected behavior and that the context menu wording is acceptable. Please let me know if any adjustments are needed.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
This is a proposal for new functionality that allows users to freeze an entire group from the group's context menu. This action freezes all nodes inside the group, including those within nested groups. Additionally, users can individually freeze/unfreeze nodes within a frozen group.
Reviewers
@QilongTang
@reddyashish
FYIs
@dnenov
@achintyabhat