Skip to content

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Mar 17, 2025

Purpose

An extension to #15915
Handle more cases that may lead to an empty group with pins.

  • Using Remove from Group context menu option.
    DynamoSandbox_3oWgCrHjhF

  • Using Alt+drag to remove from group.
    DynamoSandbox_35yp9gI7hT

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Disallow empty groups with pins #2

Reviewers

@DynamoDS/dynamo

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8469

@zeusongit zeusongit added this to the 3.5 milestone Mar 17, 2025
Copy link
Contributor

@avidit avidit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeusongit zeusongit merged commit 9b7d07c into DynamoDS:master Mar 17, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants