Skip to content

Conversation

@ivaylo-matov
Copy link
Contributor

Purpose

This PR addresses DYN-7719, where the New and Open shortcut buttons blink during graph execution in Periodic Run mode.

The flickering was caused by RunSettingsViewModel.NotifyOfGraphRunChanged, which was toggling the IsEnabled state of UI elements on every execution cycle. To resolve this, UI updates are suppressed when DynamoModel is in Periodic Run mode, preventing unnecessary changes to the shortcut buttons.

DYN-7719-Fix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Open and New shortcut buttons will no longer blink in periodic run mode.

Reviewers

@QilongTang
@reddyashish

FYIs

@dnenov
@achintyabhat

@github-actions github-actions bot changed the title Update RunSettingsViewModel.cs DYN-7719: Update RunSettingsViewModel.cs Mar 11, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7719

@ivaylo-matov ivaylo-matov changed the title DYN-7719: Update RunSettingsViewModel.cs [DYN-7719] Shortcut buttons blink on periodic mode Mar 11, 2025
@zeusongit zeusongit added this to the 3.5 milestone Mar 17, 2025
@reddyashish
Copy link
Contributor

@reddyashish reddyashish merged commit f30a3a2 into DynamoDS:master Mar 18, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants