DYN-8461: Publishing a new version of a package should reflect correct version number #15914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8461
reddyashish
approved these changes
Mar 10, 2025
twastvedt
reviewed
Mar 10, 2025
| { | ||
| if (Int32.TryParse(inputField.Text, out int value)) | ||
| var val = Int32.TryParse(inputField.Text, out int value); | ||
| if(val || value == 0) |
Contributor
There was a problem hiding this comment.
Isn't this check always true? If the parsing succeeded then val is true. If it didn't, then value has its default value of 0.
Contributor
Author
There was a problem hiding this comment.
Yes, and now we are assigning that default value in cases where TryParse is false.
Contributor
There was a problem hiding this comment.
ok, but why make an if statement that's always true?
Contributor
Author
There was a problem hiding this comment.
makes sense, updated.
twastvedt
approved these changes
Mar 10, 2025
Contributor
Author
|
Merging, unrelated failures on engops job caused by another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When deleting a version numeral from the UI, the change event skipped empty values (
""). The update should now consider empty values and update version as0.Added test
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Publishing a new version of a package should reflect correct version number
Reviewers
@DynamoDS/dynamo