DYN-5796-DynamoView-DisplayLocation-Bug #15904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When launching DynamoView in a multimonitor display and closing it in the second monitor is saving the location in the DynamoSettings.xml so the next time Dynamo is opened is putting the DynamoView in previously the saved location, then if the second display is missing DynamoView is located in a position where the user cannot interact with the Window. For fixing this problem I've added a validation for putting dynamo in the first monitor (X =0, Y = 0) when the saved location is not valid (this fix is valid for any position horizontally and vertically).
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-5796
Contributor
Author
|
@QilongTang @reddyashish |
reddyashish
approved these changes
Mar 10, 2025
Contributor
reddyashish
left a comment
There was a problem hiding this comment.
Looks good. Thanks Roberto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing bug of showing Dynamo is a not available monitor
When launching DynamoView in a multimonitor display and closing it in the second monitor is saving the location in the DynamoSettings.xml so the next time Dynamo is opened is putting the DynamoView in previously the saved location, then if the second display is missing DynamoView is located in a position where the user cannot interact with the Window. For fixing this problem I've added a validation for putting dynamo in the first monitor (X =0, Y = 0) when the saved location is not valid (this fix is valid for any position horizontally and vertically).
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing bug of showing Dynamo is a not available monitor
Reviewers
@QilongTang
FYIs
@twastvedt