-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-8208 Integrate PM Publish Wizard #15880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- consume PacMan Wizard react project - add a feature flag to toggle between the old and the new publish UI
- introduced a feature flag to control the show of the new PacMan publish interface
- wired latest changes of front end - added tests
- new routes added for submit, publish and reset - publish locally tested, works fine
- added compatibility - full properties support now - publish locally working fine
- added support form markdown handling to frontent
- added logging and error handling for both front and back end reporting to Dynamo
- error handling - markdown files cleanup
- send compatibility map from Dynamo
- support for dependencies added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8208
zeusongit
approved these changes
Mar 10, 2025
Contributor
zeusongit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The initial code that complements the Package Manager Wizard react interface https://git.autodesk.com/Dynamo/PackagePublishWizard/pull/1.
PackageManagerWizard.xaml.cswebView2projects in DynamoIsNewPMPublishWizardEnabledfeature flagPublishPackageViewModelPackageUpdateRequestto support the derealization of the package information - there might be a leaner way of doing thatInstallation
This section will change after Dynamo starts consuming the
Package Publish Wizarddirectlyindex.htmlfile inside thedistfolder of the project.DynamoCoreWpdf\Packages\PackageManagerWizard\buildBuild ActiontoResourceReact
Dynamo
WebView2 2mb limitation
Since we are using
weavefor the first time, as well as using the bespokePackageCompatibilityEditorcomponent (created by the awesomeVerateam) we have reached 3mb total bundle file size. WebView2 poses a strict 2mb limitation. In order to circumvent this limitation, we are serving the project from singleindex.html(containing all the js complied code inside) from an absolute file path generated at runtime. For more information https://weblog.west-wind.com/posts/2024/Jul/22/Work-around-the-WebView2-NavigateToString-2mb-Size-LimitDeclarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
FYIs
@achintyabhat
@deepakanand