Skip to content

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Mar 3, 2025

Purpose

The PR handles the crash based on the CER report(51756739), the crash seems to branch from updating nested group position. As a fix this is mitigated by catching the exception and logging it in console instead.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Handle crash when moving nested groups

Reviewers

@DynamoDS/dynamo

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7369

@zeusongit zeusongit marked this pull request as ready for review March 3, 2025 02:56
@zeusongit zeusongit merged commit deaa3dc into DynamoDS:master Mar 3, 2025
24 of 26 checks passed
@zeusongit zeusongit added this to the 3.5 milestone Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants