Skip to content

DYN-7268: Add IDSDK missing message when user tries to sign in from the splash screen #15845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeusongit merged 1 commit into from
Feb 21, 2025
Merged

DYN-7268: Add IDSDK missing message when user tries to sign in from the splash screen #15845

zeusongit merged 1 commit into from
Feb 21, 2025

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Feb 20, 2025

Purpose

Add IDSDK missing message when user tries to sign in from the splash screen

@QilongTang tested with splash screen enabled, and we missed this case earlier, good catch!

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Add IDSDK missing message when user tries to sign in from the splash screen

Reviewers

@DynamoDS/dynamo

github-actions[bot]
github-actions bot reviewed Feb 20, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7268

@QilongTang QilongTang added this to the 3.5 milestone Feb 20, 2025
@zeusongit
Copy link
Contributor Author

zeusongit commented Feb 21, 2025

Selfserve passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/17204/ with a different flaky test failing.

@zeusongit zeusongit merged commit 45fe04e into DynamoDS:master Feb 21, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

@reddyashish reddyashish reddyashish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

3 participants

@zeusongit @QilongTang @reddyashish